search

jackieschneider / Thomas-Allinson

0 stars 0 forks source link

Sylvia Lane Code Review #1

Open boricuamkw opened 9 months ago

boricuamkw commented 9 months ago

Hi Thomas Allinson! These are a few comments about your team's code.

At In[15], after "Berkeley Result", there is a Name Error--NameError: name 'diet_max' is not defined. To fix this, just define diet_max in a prior cell to let the cell run properly.

boricuamkw commented 9 months ago

It would be helpful to add brief descriptions of cell outputs and variables, and elaborate on markup titles; only to improve readability/provide explanations.

boricuamkw commented 9 months ago

Also, I saw another group write this in another repo; In line [8], where the API key goes, just use the "DEMO_KEY" instead of your real key. E.g. apikey = "DEMO_KEY" # Replace with a real key! "DEMO_KEY" will be slow... I think for other circumstances/projects, this is like a privacy concern. :0