search

jackjamieson2 / yarns-microsub-server

Yarns is a Microsub server that runs as a plugin on your WordPress site.
GNU General Public License v2.0
20 stars 4 forks source link

author property must be an object #75

Closed aaronpk closed 5 years ago

aaronpk commented 5 years ago

It looks like the author property of posts is just a string. It needs to be a full card object so that apps can render the author better. If you only have a name, then just only include that value.

{
  "type": "entry",
  ...
  "author": {
    "type": "card",
    "name": "Author Name",
    "url": "http://example.com",
    "photo": "http://example.com/photo.jpg"
  }
}

https://indieweb.org/Microsub-spec#card

jackjamieson2 commented 5 years ago

Pretty sure that author is always returned as an object from Yarns, but maybe I'm missing cases where only one property is present. I'll do some testing to double-check

aaronpk commented 5 years ago

I could be wrong but I assumed this screenshot was from Yarns: https://github.com/aaronpk/Monocle/issues/40#issue-448696810

I noticed that it included _permalink which is not documented in the spec, but I found that property in the Yarns source code.

jackjamieson2 commented 5 years ago

Hmm, maybe you're right. I have some parsing issues to fix with RSS feeds (#60). Will make this a priority for this week

@dshanske, If you're working on feeds in Parse-This, this issue might overlap what you're already doing. Either way I'll investigate and let you know if I think of ways to address this in Parse-This

jackjamieson2 commented 5 years ago

I'm not able to replicate this problem, but I still wrote a function to ensure that author is always an object. Pushed to dev and I'll close this issue once I merge to the master branch