search

jackjamieson2 / yarns-microsub-server

Yarns is a Microsub server that runs as a plugin on your WordPress site.
GNU General Public License v2.0
20 stars 4 forks source link

Fixes #84

Closed dshanske closed 5 years ago

dshanske commented 5 years ago

Parse This doesn't use composer autoload. It uses a built in autoload. I switched it over to the load system from Post Kinds and removed bundling all those extra files.

To update, you would run composer update. It should automatically copy files to the lib directory. If not, composer copy-files will do that. So no confusion about whether composer is being used. Including the autoload.php file automatically registers an autoloader so that when you ask for a class it will load it. Since Post Kinds uses the same loader, it should reduce trying to load the same file.

You were updating readme.md and not readme.txt. WordPress requires readme.txt. So I installed a composer function to generate readme.md from readme.txt if you run composer update-readme.

Then ran a check on the WordPress coding standards(phpcs) and found that you were using the text domains inconsistently, so I made them consistent, as well as letting it do some style fixes.

jackjamieson2 commented 5 years ago

Thanks @dshanske! I’ll review and merge this on Monday

On Sun, Jun 23, 2019 at 1:47 AM David Shanske notifications@github.com wrote:

Parse This doesn't use composer autoload. It uses a built in autoload. I switched it over to the load system from Post Kinds and removed bundling all those extra files.

To update, you would run composer update. It should automatically copy files to the lib directory. If not, composer copy-files will do that. So no confusion about whether composer is being used. Including the autoload.php file automatically registers an autoloader so that when you ask for a class it will load it. Since Post Kinds uses the same loader, it should reduce trying to load the same file.

You were updating readme.md and not readme.txt. WordPress requires readme.txt. So I installed a composer function to generate readme.md from readme.txt if you run composer update-readme.

Then ran a check on the WordPress coding standards(phpcs) and found that you were using the text domains inconsistently, so I made them consistent, as well as letting it do some style fixes.

You can view, comment on, or merge this pull request online at:

https://github.com/jackjamieson2/yarns-microsub-server/pull/84 Commit Summary

  • Remove composer as a dependency
  • Fix to new autoload rather than including composer as a dependency
  • Remove Grunt and use composer to generate readme.md from the required readme.txt
  • PHPCS Style Fixes and Fix Issue with Inconsistent Text Domain

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jackjamieson2/yarns-microsub-server/pull/84?email_source=notifications&email_token=AC5U5R3PTGKWL2HF4MCQZC3P34FA5A5CNFSM4H2YE4JKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G3EAQOA, or mute the thread https://github.com/notifications/unsubscribe-auth/AC5U5R4UN4AJIRDOWMQTXWLP34FA5ANCNFSM4H2YE4JA .