jackjamieson2 / yarns-microsub-server

Yarns is a Microsub server that runs as a plugin on your WordPress site.
GNU General Public License v2.0
20 stars 4 forks source link

Adding urlencoded feed url results in empty feeds #94

Closed bekopharm closed 4 years ago

bekopharm commented 5 years ago

Affect YarnsMicrosubServer version: 1.0.2 Affected Wordpress version: 5.2.3

Adding a feed formatted with urlencoded parameters like %3A results in invalid feed urls.

Example

Input: xs=32%3AsA Result: xs=32sA Expected: xs=32:sA

Consider using the appropriate urldecode() in PHP or decodeURI() / decodeURIComponent() in JS on adding new feeds.

Decoding URLs manually before adding them to a channel works.

jackjamieson2 commented 5 years ago

Nice catch, I'll try to take care of this and some other small changes this week