search

jackjamieson2 / yarns-microsub-server

Yarns is a Microsub server that runs as a plugin on your WordPress site.
GNU General Public License v2.0
20 stars 4 forks source link

Category should be a string or array of strings (not h-card) #98

Closed jackjamieson2 closed 4 years ago

jackjamieson2 commented 4 years ago

This post (https://boffosocko.com/2020/01/16/how-to-follow-the-complete-output-of-journalists-and-other-writers/) contains an h-card marked up as u-category. When parsed, it results in an h-card inside the category field, which isn't supported.

In alltogethernow.io, this means the entire channel's posts fail to load

In Monocle the post loads, but each of the h-card fields is displayed as a separate category. This results in a category field called card

If categories are parsed as h-cards they should be normalized to strings or arrays of strings. This can probably be done in parse this.

(Truthfully, I'm behind in updating Yarns so I should check if this has already been addressed in Parse This and update)

dshanske commented 4 years ago

https://indieweb.org/person-tag#How_to_markup That would be a person tag.

dshanske commented 4 years ago

I checked and xray actually collapses it and puts the h-card into the reference section, as noted in the jf2 spec. Parse This should probably do the same, but not a scenario I considered

jackjamieson2 commented 4 years ago

Only seems to come up rarely. Turns out to be a large problem when viewing feeds in Together though, since the whole channel fails if any feed item has field of the wrong type

On January 21, 2020 at 2:07:52 PM, David Shanske (notifications@github.com) wrote:

I checked and xray actually collapses it and puts the h-card into the reference section, as noted in the jf2 spec. Parse This should probably do the same, but not a scenario I considered

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jackjamieson2/yarns-microsub-server/issues/98?email_source=notifications&email_token=AC5U5R7AOG27A2Y4EV3JLWLQ65BYRA5CNFSM4KJYMC42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJQ4F7Y#issuecomment-576832255, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC5U5R5FLZS6ZGM2HCLNWDDQ65BYRANCNFSM4KJYMC4Q .

dshanske commented 4 years ago

@jackjamieson2 Fixed in Parse This and pushed

jackjamieson2 commented 4 years ago

Hooray! Thanks @dshanske. I'll get Yarns updated as soon as I can (tonight I hope)