jackjones2220 / cfg-loader

Automatically exported from code.google.com/p/cfg-loader
0 stars 0 forks source link

ocarina cheat code max too low (CHEAT_MAX=256) (error from parse_cheats in cheats.c) #154

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. For games like SSBB and Twilight Princess the ocarina cheat txt files 
(downloaded from http://www.usbgecko.com/codes/codes) are large (96KB, 56KB).
2. attempting to open the cheats in configuable usb loader results in error .

What is the expected output? What do you see instead?
cheat code list; instead error 

What version of the loader are you using?
69d-222

What is your System Menu version (e.g. 4.2u)?
3.some odd 

What is your media type (HDD, USB Flash, SD/SDHC)?
usb

How is your media formatted (wbfs, fat32, ntfs)?
fat32&ntfs

Which cios are you using, which version, which base (222,249,...)?
(Please try both 249 and 222 with cfg-222.dol)
222

Does it work with other loaders?
yes

Does it work with the latest or an older version?
not the latest version; no idea about older version

Please provide any additional information below.

This issue likely could be solved simply by increasing the size of the cheats 
array (e.g. CHEAT_MAX=512).

Another possible sollution may to be to dynamicaly resize the array only for 
the cases where there are more then 256 cheats maybe using realloc or malloc

Original issue reported on code.google.com by Kyla.Hue...@gmail.com on 25 Jun 2011 at 6:21

GoogleCodeExporter commented 8 years ago
or use a dedicated cheat management app...

Original comment by ogg...@gmail.com on 28 Jun 2011 at 8:26

GoogleCodeExporter commented 8 years ago
I hit this one today also please can you fix it as it is seemingly a simple fix 
i am guessing you just used a byte/int8/char for its storage type.

Original comment by andi.ire...@gmail.com on 29 Jun 2011 at 4:09