jackkoppa / cityaq

Angular PWA to compare simple air quality data for different cities, using the OpenAQ API
http://cityaq.com
7 stars 5 forks source link

Search field should have a more descriptive title/placeholder #6

Closed jackkoppa closed 6 years ago

jackkoppa commented 6 years ago

This is a:

[ ] Bug Report
[ ] Feature Request
[x] Suggestion

Desired Behavior

Search field is labelled descriptively, e.g. "Search for Cities"

Actual Behavior

Search field title is labelled "City". When people land on the page for the first time, it isn't immediately clear that they should click into this field

Specifications

jackkoppa commented 6 years ago

More descriptive label checked in w/ 3d3998f

jackkoppa commented 6 years ago

2e189d8 makes the info button less confusing as well (tenuously related)

jackkoppa commented 6 years ago

Still need to add search icon

jackkoppa commented 6 years ago

aeecfcf adds the search icon which, while functional, will likely be used primarily as a visual indicator of what the field is for. Since "Enter" and clicking on a autocomplete option both trigger the search.

Closing