search

jackkum / node-pdu

Creates and parses a SMS PDU strings
MIT License
16 stars 11 forks source link

Update Helper.js #24

Closed lipflip closed 1 year ago

lipflip commented 3 years ago

Fix for wrong 7bit decode, described here: https://github.com/jackkum/node-pdu/issues/20#issuecomment-478877023

Apollon77 commented 1 year ago

Proofed that fix by testing. We also monkey patched it in serialport-gsm (https://github.com/zabsalahid/serialport-gsm/pull/115/files)

KillerJulian commented 1 year ago

Thanks for contributing! Your changes were introduced with the pull request https://github.com/jackkum/node-pdu/pull/25 .

With kind regards Julian