jacklein / rn-bottom-drawer

a react native bottom drawer component
MIT License
186 stars 84 forks source link

cross platform testing #1

Open jacklein opened 5 years ago

jacklein commented 5 years ago

My laptop is too old to download xcode so I cannot test on an iphone x simulator to see what it looks like. I'm also working on setting up the android simulator but if anyone could test on these devices and see if there's any problems that would be great!

SoftARV commented 5 years ago

i was testing the component on my Android phone and the gestures doesn't seen to work. I have to manually change the startUp property to see my component. Is there something else i need to do to get it working? drawingdrawing

jacklein commented 5 years ago

@SoftARV can you post your code so i can look at it? i can't be sure without looking at what you've written

SoftARV commented 5 years ago

this is the render method of my component.

The constant for the sizes are 400 for the container height and 60 for the bar.

screen shot 2018-12-20 at 8 48 07 pm

jacklein commented 5 years ago

because you have a MAIN_BAR, you need to also set the offset={MAIN_BAR_SIZE}, let me know if that works.

SoftARV commented 5 years ago

I didn't set the offset because I'm not using any navbar or tabbar in my home screen as you can see in the images a put before. I'm using the whole screen for the drawer but when a try to drag my component nothing happen. maybe my component that is rendering in the drawer is pushing the draggable part away, I think?

jacklein commented 5 years ago

is there any way for you to post your entire code base or at least enough for me to be able to reproduce your problem?

SoftARV commented 5 years ago

let me upload my project to GitHub. I was planning on doing it but never have the necessity yet.

jacklein commented 5 years ago

can you show me what styles.modalContainer looks like

SoftARV commented 5 years ago

It only has the height of the container at 400. Here is the repo of my project https://github.com/SoftARV/Todo-App

jacklein commented 5 years ago

i bet it has something to do with the bottom drawer's parent component. try taking it out of the view and instead make it it's sibling? i'll copy the repo and mess around with it too. damn i hope we can figure this out :0

jacklein commented 5 years ago

actually sorry i cant play with your project because i have to use the Expo ide which can only run javascript. if you can play around with it more and try to debug it i would be very grateful.

SoftARV commented 5 years ago

sure no problem, I figure it out. if anything change I'll let you know. and yeah I'm not using expo right now, just learning all the ropes with React Native only.

jacklein commented 5 years ago

yeah unfortunately my mac os is too old for xcode so theres not much i can do about it haha.

and ok, keep me updated! and if you think it's a bug within this repo, feel free to make a PR!!

jacklein commented 5 years ago

@SoftARV i just made the api wayyyyyy more simple and imo way better. can you try using it again and let me know if it works? thanks!

zacler commented 5 years ago

@jacklein - we are having some issues using this - animations are off and it doesn't scroll - any thoughts?

jacklein commented 5 years ago

@zacler sorry I’ve been busy starting a new job and I’ve been quite unresponsive :/ but have you looked at the solution posed on the other open issue?

zacler commented 5 years ago

It’s okay - congrats on the new job.

We went with another build I believe but will check.

Best,

Zach

Sent from my iPhone

On Feb 27, 2019, at 8:35 PM, Jack Klein notifications@github.com wrote:

@zacler sorry I’ve been busy starting a new job and I’ve been quite unresponsive :/ but have you looked at the solution posed on the other open issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.