Sorting is broken - Githubissues

jacklone / browserscope

Automatically exported from code.google.com/p/browserscope

Apache License 2.0

0 stars 0 forks source link

Sorting is broken #230

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

What steps will reproduce the problem?
1. Go to "Selectors API" tab
2. Click "score" column header (twice to get the same as on the attached 
screenshot)
3.

What is the expected output? What do you see instead?
It looks like 56.5% > 100%

What version of the product are you using? On what operating system?

Please provide any additional information below.

Original issue reported on code.google.com by rafalf...@gmail.com on 12 Jul 2010 at 5:29

Attachments:

[sorting error.png](https://storage.googleapis.com/google-code-attachments/browserscope/issue-230/comment-0/sorting error.png)

GoogleCodeExporter commented 8 years ago

My browser is Chrome 5.0.375.99, Windows platform

Original comment by rafalf...@gmail.com on 12 Jul 2010 at 5:31

GoogleCodeExporter commented 8 years ago

The sorting seems to be lexicographically (dictionary order) instead of 
chronologically. Could we improve this to check for the presence of numbers (or 
numbers as strings) and then sort chronologically instead?

Original comment by fearphage on 8 Nov 2010 at 8:39

GoogleCodeExporter commented 8 years ago

I'm working on this actually as we speak - I'm going to update our results 
tables to use more of a JS-aware component that has this functionality baked in.

Original comment by els...@gmail.com on 8 Nov 2010 at 11:52

Changed state: Accepted

GoogleCodeExporter commented 8 years ago

I tried to briefly comb through the code and didn't immediately see the area to 
target the fix. If it's not automatic, could you please link the changeset when 
you fix this. And thank you.

Original comment by fearphage on 9 Nov 2010 at 2:45

GoogleCodeExporter commented 8 years ago

Yeah, it's not at all checked in yet - still trying to get things working here 
in code on my end. ;)

Original comment by els...@gmail.com on 9 Nov 2010 at 3:04

GoogleCodeExporter commented 8 years ago

This issue was closed by revision r813.

Original comment by els...@gmail.com on 10 May 2011 at 5:08

Changed state: Fixed

GoogleCodeExporter commented 8 years ago

This issue was closed by revision r813.

Original comment by els...@gmail.com on 10 May 2011 at 5:12