wget fails

[stevefxp1]

Hello,

I am building a custom pihole image and your wget command is failing at the end. I would add wget to your run command that installs php items, as it looks like wget is not installed natively.

[jacklul]

You mean the install command in Dockerfile? I see that wget is in there

[stevefxp1]

You need to add it to the first RUN command, as its not installed natively. If you do not then the second RUN fails with wget not found.

[jacklul]

I don't understand... https://github.com/jacklul/pihole-updatelists/blob/master/Dockerfile

[stevefxp1]

Aha...your Readme is the issue. It has an old example that I was following.

[stevefxp1]

OK so I decided to use your updated Dockerfile but I have a couple of questions:

1) Why do you have a copy of the install.sh in line 2 when it does not exist yet. Isnt this part of the file when you issue the wget?

[jacklul]

Because the Dockerfile in the repository assumes you have the repository cloned in the same directory, it's for automatic building of the image mostly I've updated example Dockerfile in the readme

[stevefxp1]

Ahh...ok makes sense.

You call out the ability to edit your configuration file with nano but it does not seem you include nano in your image. You might want to review that. I took your image and added nano and good to go on editing the configuration file.

[jacklul]

Why edit it inside the container when you can edit those through mounted volumes?

[stevefxp1]

Hmmm...never really thought about doing it that way.

On Mon, Jul 11, 2022 at 2:40 AM jacklul @.***> wrote:

Why edit it inside the container when you can edit those through mounted volumes?

— Reply to this email directly, view it on GitHub https://github.com/jacklul/pihole-updatelists/issues/109#issuecomment-1180023844, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ5ST4UL7I2PIFJLX6EFS5LVTO6VHANCNFSM526VCYMA . You are receiving this because you authored the thread.Message ID: @.***>