jacklul / pihole-updatelists

Update Pi-hole's lists from remote sources easily
MIT License
1.39k stars 81 forks source link

Docker volumes ./etc-pihole-updatelists/ is not utilized #116

Closed Frostymnl closed 1 year ago

Frostymnl commented 1 year ago

When using the sample docker-compose it seems the custom configuration you set up in ./etc-pihole-updatelists/pihole-updatelists.conf are not being utilized.

Steps to reproduce:

version: "3"

services:
  pihole:
    container_name: pihole
    image: jacklul/pihole:latest
    ports:
      - "53:53/tcp"
      - "53:53/udp"
      - "67:67/udp"
      - "80:80/tcp"
    environment:
      TZ: 'America/Chicago'
    volumes:
      - './etc-pihole/:/etc/pihole/'
      - './etc-dnsmasq.d/:/etc/dnsmasq.d/'
      - './etc-pihole-updatelists/:/etc/pihole-updatelists/'
    cap_add:
      - NET_ADMIN
    restart: unless-stopped

; Remote list URL containing list of adlists to import ; URLs to single adlists are not supported here! ADLISTS_URL="https://v.firebog.net/hosts/lists.php?type=tick"

; Remote list URL containing exact domains to whitelist WHITELIST_URL="https://raw.githubusercontent.com/anudeepND/whitelist/master/domains/whitelist.txt"

; Remote list URL containing regex rules for whitelisting REGEX_WHITELIST_URL=""

; Remote list URL containing exact domains to blacklist ; This is specifically for handcrafted lists only, do not use regular blocklists here! BLACKLIST_URL=""

; Remote list URL containing regex rules for blacklisting REGEX_BLACKLIST_URL="https://raw.githubusercontent.com/mmotti/pihole-regex/master/regex.list"



- run docker-compose

**Expected Results:**
Values from  {host-machine}/etc-pihole-updatelists/pihole-updatelists.conf that I updated are being used

**Actual Results**
Values from [{docker-machine}/etc/pihole-updatelists.conf](https://github.com/jacklul/pihole-updatelists/blob/master/pihole-updatelists.conf) are being used

**Recomendation**
I think the issue was caused by commit [6a1c060830](https://github.com/jacklul/pihole-updatelists/commit/6a1c060830076fc831a126f2aac47ba0cf127379#r83056758).
jacklul commented 1 year ago

It shouldn't because I specifically use --config parameter here to force the new location -> https://github.com/jacklul/pihole-updatelists/blob/master/install.sh#L184 and if it didn't work it would error out

jacklul commented 1 year ago

Doesn't seem to happen in my virtual machine, although the instance doesn't start properly ([✗] DNS resolution is not available bug?) I can see from the log file that it used the config in the mounted volume.

Frostymnl commented 1 year ago

Yeah, I located the log file too, and it said that it is using the config from the mounted volume, but if my memory is correct it was not reflecting that on the UI. When I have a second I will try spinning this up again from scratch.