search

jacklul / pihole-updatelists

Update Pi-hole's lists from remote sources easily
MIT License
1.44k stars 84 forks source link

Support configuration via environment variables #123

Closed andrewfraley closed 1 year ago

andrewfraley commented 1 year ago

First off, thanks for this, this seems to be the best way to manage external lists in pihole containers. It would be great if some of the config could be set as environment variables. The use case is for running in Docker, it would be great not to have to touch anything except set WHITELIST_URL as an environment variable for the container, then updatelists could pick it up from there. Apologies if this functionality already exists, but I wasn't able to find it. Thanks!

jacklul commented 1 year ago

That's something I won't be able to implement currently - you will have to use config instead.

jacklul commented 1 year ago

Found some time to work on this - will be available soon.

jacklul commented 1 year ago

Implemented in dev branch and image for now - https://github.com/jacklul/pihole-updatelists/tree/1130290cd37404a7cdf20d937cf4ce210ecd3098

Usage is as simple as you might think https://github.com/jacklul/pihole-updatelists/tree/1130290cd37404a7cdf20d937cf4ce210ecd3098#container-configuration

andrewfraley commented 1 year ago

This is perfect, thanks!

jacklul commented 1 year ago

This should now be in master and latest image