jacklul / pihole-updatelists

Update Pi-hole's lists from remote sources easily
MIT License
1.39k stars 81 forks source link

[Please Ignore] #135

Closed Ellis-808 closed 1 year ago

Ellis-808 commented 1 year ago

I suspect that URL's containing the encoded space (%20) value will cause issues when parsing the ADLISTS_URL option. The documentation states that ADLISTS_URL can contain a list of whitespace-separated URL's yet when I add a URL containing the value %20 within the URL it fails to parse.

Suggestions to fix:

  1. Add another config option ADLISTS_SEPARATOR to allow a custom delimiter OR
  2. Default to using a newline separator (easier to read when editing the .conf file manually :)

Attached image shows the error message I received (expected more URL's after the last one with the error msg) image