search

jackm / kijiji-manager

App for viewing, posting, reposting, and deleting your Kijiji ads
https://pypi.org/project/kijiji-manager/
MIT License
52 stars 11 forks source link

Server crashes when payment pending for ad #8

Open frazzydee opened 3 years ago

frazzydee commented 3 years ago

First of all thank you for this amazing tool.

The other day, when experimenting with this newly installed package, I kept getting an error 5000.

I believe it was because I accidentally posted too many ads. That's when the problem started, and it resolved after I deleted it.

If that is the case, then when payment is pending on an ad (for example, if you exceed 2 ads in the Real Estate or Cars & Vehicles sections), the server throws an error.

Note the log: https://pastebin.com/Q7NevnV1

There would not be a page number if payment is pending (the ad isn't posted yet, but rather in a pending state).

Steps to reproduce: (have not tried a second time as I'm worried my account will get flagged given how many times I've done this already when experimenting)

  1. Post an ad in the real estate section.
  2. Do it again (now 2 ads)
  3. Do it again (now 3 ads)

Expected results: You are able to log into kijiji-manager and view your ad. Ideally it would note that the ad is "Payment pending" similar to the Kijiji website.

Actual results: Server throws an error 5000. You cannot do anything, including log out of your profile. Theoretically can be fixed if you delete the "payment pending" ad from the kijiji website.

jackm commented 3 years ago

This is indeed an untested part of the code when it comes to Kijiji limiting the number of ads in a certain category or when payments to Kijiji come into play. This needs further investigation.

The issue when a page number does not exist for an ad is fixed in commit 0f62e0a