search

jackmellis / require-extension-hooks

Add hooks for js extension types
17 stars 2 forks source link

Required Node version #9

Closed stribny closed 6 years ago

stribny commented 7 years ago

Hello!

First of all, thanks for the contribution to the open source community! I discovered this package because I was trying to test my Vue components.

I just want to make a suggestion to provide required Node version in the package.json file. I was running into errors importing this module and the solution was to update Node. I am sure I might not be the only one struggling, hence I recommend to specify for which version of Node this package is written.

Thanks and have a nice day, Petr

jackmellis commented 7 years ago

Sounds like a good idea to me. Can you confirm what version of node you were on?

stribny commented 7 years ago

I had 6.6.0 or something similar and it didn't work, so I updated to 8.6.0. I suggest to check if the package works with the LTS version of Node as I imagine a lot of people can be running on it.

jackmellis commented 7 years ago

On second thoughts. I have a feeling this will be fixed by this yet-to-be-released PR: https://github.com/jackmellis/require-extension-hooks/pull/8

I believe this was to do with some node 6.x incompatible code.

stribny commented 6 years ago

Sure, this could be it. It is up to you - but it is still a good practice.