search

jackmoore / colorbox

A light-weight, customizable lightbox plugin for jQuery
http://www.jacklmoore.com/colorbox/
MIT License
4.75k stars 1.14k forks source link

Migration to 1.4 and close button customization broken #350

Open cadilhac opened 11 years ago

cadilhac commented 11 years ago

Hi,

Because I switched to jquery 1.9 I had also to update to your latest version. Unfortunately, something is broken in how I was customizing the close area to show 2 buttons Yes and No.

Now, my 2 div tags are put in a Button tag by your code...

How can I still achieve my 2 buttons?

Thanks

jackmoore commented 11 years ago

I overlooked that use case when I made that update. For the moment you can use the last version before the button update: https://github.com/jackmoore/colorbox/tree/1.3.34

The only important thing that has changed since then was the button markup, and I'll try to work out a solution that allows the close button to be a button but also allows alternative markup.

cadilhac commented 11 years ago

Thanks, 1.3.34 is ok for me.