search

jackmoore / colorbox

A light-weight, customizable lightbox plugin for jQuery
http://www.jacklmoore.com/colorbox/
MIT License
4.75k stars 1.14k forks source link

rel -> data-rel #823

Closed nuykon closed 7 years ago

nuykon commented 7 years ago

Bad value something for attribute rel on element a: The string something is not a registered keyword. <a rel='something'> - not valid html code in HTML5 <a data-rel='something'> - valid html code in HTML5

https://www.w3.org/TR/html5/links.html#linkTypes http://microformats.org/wiki/existing-rel-values#HTML5_link_type_extensions

jackmoore commented 7 years ago

Thanks for the pull request. I agree with your suggestion, but I'm not going to merge this due for backward compatibility reasons (Colorbox is very old now and I want those legacy users to be able to incorporate important fixes without breakage). If Colorbox ever gets a rewrite, I'll be sure to drop the use of the rel attribute.

However, this is already something you can do by using the data-cbox-rel attribute, which has priority over options object rel property. I never documented the use of cbox-rel-* attributes, my apologies for that.