Wrap with UMD to make it AMD compatible without config.shim neccesity

jackmoore / colorbox

A light-weight, customizable lightbox plugin for jQuery

http://www.jacklmoore.com/colorbox/

MIT License

4.75k stars 1.14k forks source link

Wrap with UMD to make it AMD compatible without config.shim neccesity #857

Open ericnewton76 opened 6 years ago

ericnewton76 commented 6 years ago

UMD factory like https://gist.github.com/simonsmith/4353587

Simple to wrap. Correctly attaches colorbox functionality to jQuery instance that will be handed to other functions calling require('jquery'), without needing to use (requirejs) config.shim

hamishrouse commented 4 years ago

The following I believe is an example of this: https://github.com/Sioweb/colorbox/blob/master/jquery.colorbox.js

drakanor commented 11 months ago

That would be great and also make it to be usable with stuff like Vite.