search

jackmoore / colorbox

A light-weight, customizable lightbox plugin for jQuery
http://www.jacklmoore.com/colorbox/
MIT License
4.75k stars 1.14k forks source link

Use `peerDependencies` for jQuery #896

Closed mpdude closed 3 years ago

mpdude commented 3 years ago

Would it make sense to specify jquery as a peerDependency to make sure it matches the version of jQuery the main project installs?

jackmoore commented 3 years ago

Yes, that makes sense and thank you for the PR! I hate to make any changes since Colorbox use is almost entirely legacy, but I'm having trouble thinking of a way this is going to mess anyone up.