search

jackmoore / zoom

jQuery plugin for zooming images on mouseover.
http://www.jacklmoore.com/zoom/
MIT License
1.54k stars 460 forks source link

[enhancement] What about a build script #84

Open ppowalowski opened 9 years ago

ppowalowski commented 9 years ago

The repo contains a minimized version. There is no automated buildscript to build a minimized version - If contributors change the source of jquery.zoom.js there is no predefined way to build the ´ jquery.zoom.min.js´ file. Either every contributor finds a way to minimize the file(alowing inconsistent results) or they won't build the code at all so PRs will become unmergable without intervention causing longer developemt cycles.

I suggest gulp or something morge minimalistic like the usage of npm itself for building

tuomassalo commented 8 years ago

I ran into the same question. See my PR: https://github.com/jackmoore/zoom/pull/100/files#diff-0730bb7c2e8f9ea2438b52e419dd86c9R5

jackmoore commented 8 years ago

Thanks, and sorry about the lack of a build script. I keep a private build script that did the minification, lint, bumped the bower and package json files, and published to npm since contributors wouldn't be concerned with most of that. I don't actually want pull requests with minified files, just to be on the safe side. But, I should separate the source from the versioned distribution files and add a build process.