search

jackocnr / intl-tel-input

A JavaScript plugin for entering and validating international telephone numbers. React and Vue components also included.
https://intl-tel-input.com
MIT License
7.69k stars 1.95k forks source link

Contributing to previous versions. Upgrading a previous version of intl-tel-input [ Discussion ] #1844

Closed Ryan-Boustany closed 1 month ago

Ryan-Boustany commented 1 month ago

With regards to how my repository is set up I am looking update libphonenumber library on version 17.0.21. I checked and it is indeed possible to make that upgrade. It'll be much more effective and require much less change to the overall structure of my project. How am I able to go about achieving this change?/How can i contribute to previous versions?

Any Advice is greatly appreciated!

jackocnr commented 1 month ago

v17 was a long time ago, so I would strongly recommend you upgrade for all sorts of bug fixes and improvements.

With that said, it should be possible to stay with that version and upgrade libphonenumber, if that's what you want to do.

First you'll need to fork the repo, so you have your own copy which you can push changes to, and then switch your project to use that repo instead of this one.

After you've forked the repo, you can clone it, and then checkout v17.0.21. Then, you should be able to follow the instructions in .github/CONTRIBUTING.md on how to update libphonenumber from there.

For reference, here's a link to the contributing instructions at v17.0.21

Ryan-Boustany commented 1 month ago

@jackocnr Just had a questions:

  1. Does that mean that in my package.json I will be including my newly forked repo instead of this one (intl-tel-input)?
  2. To follow, my changes wont be included in a 17.0.22 tag in this repo?
jackocnr commented 1 month ago

Does that mean that in my package.json...

That's right, in your package.json you'll be loading the plugin from Ryan-Boustany/intl-tel-input instead - I can't remember the exact syntax - it should be easy to google how to load a package from a custom fork.

To follow, my changes wont be included in a 17.0.22 tag in this repo?

That's correct. You'll create a new tag in your forked repo, which you can then load in your package.json to get the updated version, but that wont impact this repo at all (jackocnr/intl-tel-input).