search

jackofsporks / blockit

Saner coding
0 stars 0 forks source link

This seems like a fragile way to update a block #81

Closed jackofsporks closed 6 years ago

jackofsporks commented 6 years ago

// Updating the token too...?? // get one word/parts of word + change start and end index + ??? // + find matching values const block = {...previousBlock} if (action === "delete") block.endIndex -= 1 else if (action === "insert") block.endIndex += 1 }

opened via imdone.io from a code comment on 022c7057 by jackofsporks

https://github.com/jackofsporks/blockit/blob/70af5f49ac3561692612ecc5d71cae8977c5e35d/lib/control/Locator.js#L428-L440

jackofsporks commented 6 years ago

TODO This seems like a fragile way to update a block id:75 gh:81 ic:gh

https://github.com/jackofsporks/blockit/blob/70af5f49ac3561692612ecc5d71cae8977c5e35d/lib/control/Locator.js#L428-L440

jackofsporks commented 6 years ago

TODO This seems like a fragile way to update a block id:75 gh:81 ic:gh

https://github.com/jackofsporks/blockit/blob/11745c0692aa22c71879cbf9f303cf52e27f3ba7/lib/control/Locator.js#L429-L441

jackofsporks commented 6 years ago

TODO This seems like a fragile way to update a block id:75 gh:81 ic:gh

https://github.com/jackofsporks/blockit/blob/57e9444397afe1d4ba3eb8d4ec8e6b12d63d0ce2/lib/control/Locator.js#L42-L54

jackofsporks commented 6 years ago

TODO This seems like a fragile way to update a block id:75 gh:81 ic:gh

https://github.com/jackofsporks/blockit/blob/651d39fa3d5792e18947076ba0075814e196fcd4/lib/control/Locator.js#L45-L57

jackofsporks commented 6 years ago

Issue closed with imdone.io by removing a comment.

https://github.com/jackofsporks/blockit/blob/ad4bb68151c0b70f84d7e5b0af56743efe07b93b/lib/control/Locator.js#L45-L57