Build fails with Rack build system

jackokring / KRTPluginA

Another later version VCV rack repo.

Other

6 stars 0 forks source link

Build fails with Rack build system #1

Closed cschol closed 2 years ago

cschol commented 2 years ago

The Makefile defines the RACK_DIR environment variable incorrectly.

Here is the patch that fixes the build issue:

diff --git a/Makefile b/Makefile
index 94b7cba..5d23299 100644
--- a/Makefile
+++ b/Makefile
@@ -1,6 +1,5 @@
 # If RACK_DIR is not defined when calling the Makefile, default to two directories above
-#RACK_DIR ?= ../..
-RACK_DIR = ..
+RACK_DIR ?= ../..

 # FLAGS will be passed to both the C and C++ compiler
 FLAGS +=

squinkylabs commented 2 years ago

I think this is related to the issue of calling the repo "VCV". it's as if the author's repo is not in a folder that is a direct child of the plugins folder.

jackokring commented 2 years ago

Rack/Rack-SDK/KRTPluginA is the local build tree in my user folder. Built-in KRTPluginA folder. Repo renamed https://github.com/jackokring/VCVPlugins

jackokring commented 2 years ago

Fixed build by having an extra Plugins directory.