jackpine / biketag-ios

http://biketag.jackpine.me
1 stars 1 forks source link

Feature/cukes for correct spot #106

Closed michaelkirk closed 8 years ago

michaelkirk commented 8 years ago

rebased against master.

@jmoody can you test this?

I can't get it past the tap("view marked:'pretend I was right'")

Note that you originally had tap("view marked:'(pretend I was right)'") which I couldn't get to work either. You also didn't have an accessibilityIdentifier set for that element in your PR #93 (that I could see).

My approach was to add an AID to the button "pretend I was right" and then change the cuke to look for "pretend I was right" instead of "(pretend I was right)" as that's in line with the rest of your steps. But no dice.

Any insight?

I'm running it on the simulator.

jmoody commented 8 years ago

@michaelkirk

I could not get the app to build out-of-the box; Carthage could not build AlamoFire.

It was the MacOS target that was failing, so I did this:

$ carthage bootstrap --platform iOS
jmoody commented 8 years ago

re: "(pretend I was right)"

Since this is text that will never be localized (it only appears while testing), I opted for just matching the string directly.

All the Steps passed for me:

$ make app
$ be cucumber -t @correct_spot
 @correct_spot
  Scenario: Submitting the correct spot            # features/game/guess_a_spot.feature:9
    Given I'm looking at the list of current spots # features/steps/guess_a_spot_steps.rb:24
    And I guess correctly for the first one        # features/steps/guess_a_spot_steps.rb:30
    Then I should see that I was correct           # features/steps/guess_a_spot_steps.rb:42
    And I should be prompted to submit a new spot  # features/steps/guess_a_spot_steps.rb:46
    When I submit the next spot                    # features/steps/guess_a_spot_steps.rb:50
    Then my new spot should be the current spot    # features/steps/guess_a_spot_steps.rb:57

Perhaps you had a stale binary on the simulator?

michaelkirk commented 8 years ago

Yeah.. stale I guess. Passing now! Woohoo! :+1: thanks @jmoody

jmoody commented 8 years ago

:8ball:

Glad this got merged. :)