search

jackpocket / jsoneditor-rails

This gem packages the JSON Editor assets for the Rails asset pipeline.
MIT License
15 stars 6 forks source link

Update for use with propshaft gem. #115

Open StephenVNelson opened 2 months ago

StephenVNelson commented 2 months ago

I am not sure if this is out of scope for this gem, but I had to make a small tweak to use this gem with propshaft. The sprockets shortcuts for URLs to assets no longer work, so I had to update them to a simple url() as described here.

Not sure if anybody else would appreciate this or if this gem is still being maintained but we've really appreciated using it and would be happy to contribute if necessary.

javierjulio commented 2 months ago

@StephenVNelson you're very welcome. Yes this gem is being maintained. We just aren't using propshaft. We'd welcome a contribution to support it alongside sprockets.

From reviewing the docs it sounds like we'd have to separate the vendor assets, one version for each, or find some other way. Unless I'm missing something from what you shared, the CSS should work with propshaft without any modifications, right? Can you please confirm if you build the assets after updating the following method to do nothing, that it works with propshaft?

https://github.com/jackpocket/jsoneditor-rails/blob/099f99b3c40e268df9d1fdcc83f0846cdd3d4835/Rakefile#L26-L30