Filter Overheads does not filter overhead messages.

jackriccomini / spamfilter-plugin-runelite

Spam filter plugin for RuneLite

MIT License

8 stars 6 forks source link

Filter Overheads does not filter overhead messages. #12

Open SoggyBurritoVR opened 1 year ago

SoggyBurritoVR commented 1 year ago

Messages that are blocked in "public" are not blocked in overhead chat.

Spam still displays in overhead.

Included image showing blocked messages in public, while displaying on overhead.

My Settings if needed.

jackriccomini commented 1 year ago

I think this could be a dupe of https://github.com/jackriccomini/spamfilter-plugin-runelite/issues/10. The issue there was that whitespace at the start of a message would cause it to be processed inconsistently by the chatbox and overhead filters. I have fixed that, however in your screenshot the message from e.g. "Coin PN54" doesn't seem to have any extra whitespace which would suggest it's a different underlying issue.

I will keep this issue open. After 1.0.1 releases (track it here) could you comment whether you still experience the issue? If you do experience it then there must be a different problem.

SoggyBurritoVR commented 1 year ago

I'm decently new to git, has the 1.0.1 version been released as of today?

Tried to keep up with the link you posted, but unsure what I'm really looking at.

jackriccomini commented 1 year ago

I'm decently new to git, has the 1.0.1 version been released as of today?

Tried to keep up with the link you posted, but unsure what I'm really looking at.

It released yesterday. If you check the link you will see it now says "merged" with a purple icon

yungando commented 1 year ago

There does still seem to be an issue with overhead filtering. Most of the unfiltered overheads used chat effects, that might be contributing to the issue?

cs4296 commented 1 year ago

I think I figured out the issue. Whenever the Chat Filter plug-in is turned on, the overhead messages are not filtered.

jackriccomini commented 1 year ago

I think I figured out the issue. Whenever the Chat Filter plug-in is turned on, the overhead messages are not filtered.

Thank you! A had a branch for this last year which I never ended up merging but which I think should still work. When I have my dev environment set up again I will test it and hopefully be able to close this issue

Daggerdoc commented 7 months ago

Hey, ik this issue is pretty old but has any workarounds been found?

jackriccomini commented 7 months ago

Hey, ik this issue is pretty old but has any workarounds been found?

IIRC this has been fixed in the master branch. The version containing the fix has not yet been released to the plugin hub. I made a PR here to release to the plugin hub at the time I fixed the issue. The checks failed because this plugin was originally written to use APIs that have since been deprecated. I made a mental note at the time to fix it when I next had a chance and it's been on my mental todo list ever since. The next time I am doing any work on this plugin, my priority will be to fix the use of that deprecated API so I can get the previous bugfixes released to the plugin hub. I am not sure when that will be. Until then, the best workaround is to disable the chat filter plugin.