Closed weiyx16 closed 4 years ago
Thanks for your feedback! Really sorry that I didn't carefully check this part. I would make an update or would you like to create a PR? Thanks again for your great work!
You are welcome! Sure. But to be honest, most of the mistakes occur in another repo, I will just create a PR in that repo. Is that ok? Thank you for your reply!
Sure. Thanks!
I have already created a pr in that repo and you can merge it for better usage.
@weiyx16 I just found another mistake about max boxes number in the repo. You can refer to this issue for details.
@weiyx16 I just found another mistake about max boxes number in the repo. You can refer to this issue for details.
Since for the first time to do the reproduce, I used 36 bbox, so I can report another interesting ablation. For RefCOCO+ Detected Regions val, in src paper:
in my setting:
It seems that in this task, if you add ep to src setting, the gap between different bbox or precomputed or not is really small.
When I wanted to extract img feature from conceptual-captions following the instructions, I found some errors during inference with this file and it took me sometime to debug and I'd like to share with you:
Firstly, the calling script should be:
A little mistake in --def params
Secondly, in Line46 and Line54, should be:
Thirdly, in Line67, should be:
Fourthly, in Line142, we need another params:
And correspondly, in Line170, the same problem:
Really thank you for your sharing of the code!