search

jackrusher / mundaneum

A clojure wrapper around WikiData
BSD Zero Clause License
127 stars 16 forks source link

Add a VALUES clause #14

Closed zachcp closed 2 years ago

zachcp commented 4 years ago

PR addressing #13

Couple of thoughts.

  1. I had to use eval directly to interpret the symbol. Is there a safer way? Your other uses of eval are limited to the NS.
  2. I just noticed the text edits for spacing parens - this was auto-changed by the editor (Cursive)
jackrusher commented 2 years ago

@zachcp I'm going to address this in the next week or so with what amounts to a complete re-write.