search

jacksalici / salinger-theme

A clean and minimalistic Hugo theme for personal blogs and portfolios. Built with TailwindCSS and DaisyUI.
https://github.com/jacksalici/salinger-theme
MIT License
33 stars 12 forks source link

Cannot close menus on iOS #1

Closed p-gentili closed 1 year ago

p-gentili commented 1 year ago

Using any iOS browser, it's not possible to close the menu without tapping on one entry. It happens for both menus: header and footer.

How to reproduce

  1. Visit the demo website
  2. Tap on the hamburger menu
  3. Tap outside of the menu view list to close it

Expected result: the menu view disappears Actual result: the menu view is still there

jacksalici commented 1 year ago

Hello, thank you for have reached me. I will investigate further the problem. Actually, the menus are handled by DaisyUI, so the odds are that the problem is there.

p-gentili commented 1 year ago

Hello, thank you for have reached me. I will investigate further the problem. Actually, the menus are handled by DaisyUI, so the odds are that the problem is there.

Mh right, I can see there are a couple of related issues on their repo:

  1. https://github.com/saadeghi/daisyui/issues/234
  2. https://github.com/saadeghi/daisyui/issues/1737

The workaround seems to be on the user side though. Thanks!

EDIT: if you don't have a device to test it just reach me out.

jacksalici commented 1 year ago

Thanks for the reference, I keep this issue open until will understand better the problem. I'm going to update you in a couple of days.

jacksalici commented 1 year ago

Hello, with the last commits, I should have solved the bug. I tried it on my iPad and it worked fine, if you want to check on your device too, then I will create a new release and close the issue. Thank you.

p-gentili commented 1 year ago

It works beautifully, TYVM.