jackschedel
commented
1 year ago Re-opening this bc fixing the auto-scrolling when changing doing focus and changing cursor position was far more involved than expected I spent about 3 hours messing with it with no success, so this likely needs to be implemented in another way, maybe when the edit button is pressed (or generation is done) so it only runs once. useEffect on textarearef winds up calling it 3 times.
I'll accept the PR if you can change it so that:
- the build tests work and the diffs are only in the relevant files
- the cursor goes to the end of any existing text if in EditView. (I was able to do this with
textareaRef.current.selectionStart = textareaRef.current.value.length;in a dedicated onEffect that only runs once, otherwise the cursor will constantly be jumping to the end) - there is no automatic window scrolling (this is the hard part)
cheeseonamonkey
@cheeseonamonkey in the future please make sure to use a dedicated branch rather than main so your new commits don't accidentally come into the PR unintentionally.
Cherry picking your
auto-focus new textareascommit with the added tweak of making the cursor automatically go to the end of the text when editing in #83Also, please either set up Deno LSP formatting or try to make sure your git diffs only have the relevant lines changed. I don't mind running the autoformat for the commits myself but it makes it a lot easier to review, plus autoformat makes pasting in code from LLM's alot easier ; )