search

jacksenechal / Skype-for-Chrome

Creates Skype callto: links out of phone numbers in the page, so you can click to dial them.
BSD 3-Clause "New" or "Revised" License
8 stars 8 forks source link

Causes some page text with angle brackets to be hidden #8

Closed halr9000 closed 9 years ago

halr9000 commented 11 years ago

I just found that when this extension is enabled, I was unable to view some text on certain webpages. I narrowed it down to a quick repro:

  1. enable extension
  2. visit http://docs.splunk.com/Documentation/Splunk/latest/admin/Propsconf
  3. search for "for a given".

The sentence near the search result should display (I've replaced angle brackets with square brackets): "This stanza enables properties for a given [spec].". What is happening is that the portion including [spec] is hidden, but only when this extension is enabled.

To validate that this is a display issue, and not server-side:

  1. View source of same webpage
  2. search for "for a given"
  3. Note that the HTML source includes: "This stanza enables properties for a given <spec>."
jacksenechal commented 11 years ago

Thanks for reporting this. Have you seen this on any other webpages? I see the described behavior on the page you linked, but I'm unable to replicate it on a test page.

It looks like there are some significant rewrites that I have to do in order to get the plugin up to the latest API, so I'll have to work on that before I can actually dive into the problem.

Best, Jack

On Tue, Nov 27, 2012 at 9:27 AM, Hal Rottenberg notifications@github.comwrote:

I just found that when this extension is enabled, I was unable to view some text on certain webpages. I narrowed it down to a quick repro:

  1. enable extension
  2. visit http://docs.splunk.com/Documentation/Splunk/latest/admin/Propsconf
  3. search for "for a given".

The sentence near the search result should display: "This stanza enables properties for a given .". What is happening is that the portion "" is hidden, but only when this extension is enabled.

To validate that this is a display issue, and not server-side:

  1. View source of same webpage
  2. search for "for a given"
  3. Note that the HTML source includes: "This stanza enables properties for a given ."

— Reply to this email directly or view it on GitHubhttps://github.com/jacksenechal/Skype-for-Chrome/issues/8.

halr9000 commented 11 years ago

Hey. No, haven't seen anything like this on other websites. But I work for Splunk, so couldn't afford to not be able to read our docs. :)

On Fri, Nov 30, 2012 at 1:13 AM, Jack Senechal notifications@github.comwrote:

Thanks for reporting this. Have you seen this on any other webpages? I see the described behavior on the page you linked, but I'm unable to replicate it on a test page.

It looks like there are some significant rewrites that I have to do in order to get the plugin up to the latest API, so I'll have to work on that before I can actually dive into the problem.

Best, Jack

On Tue, Nov 27, 2012 at 9:27 AM, Hal Rottenberg notifications@github.comwrote:

I just found that when this extension is enabled, I was unable to view some text on certain webpages. I narrowed it down to a quick repro:

  1. enable extension
  2. visit http://docs.splunk.com/Documentation/Splunk/latest/admin/Propsconf
  3. search for "for a given".

The sentence near the search result should display: "This stanza enables properties for a given .". What is happening is that the portion "" is hidden, but only when this extension is enabled.

To validate that this is a display issue, and not server-side:

  1. View source of same webpage
  2. search for "for a given"
  3. Note that the HTML source includes: "This stanza enables properties for a given ."

— Reply to this email directly or view it on GitHub< https://github.com/jacksenechal/Skype-for-Chrome/issues/8>.

— Reply to this email directly or view it on GitHubhttps://github.com/jacksenechal/Skype-for-Chrome/issues/8#issuecomment-10879677.

Hal Rottenberg / hal@halr9000.com / halr9000.com Microsoft MVP (PowerShell) / VMware vExpert Co-Host, PowerScripting Podcast (http://powerscripting.net)

"Managing VMware Infrastructure with PowerShell: TFM", now shipping!

Follow me on Twitter http://twitter.com/halr9000, LinkedInhttp://www.linkedin.com/in/halrottenberg

jacksenechal commented 9 years ago

https://github.com/jacksenechal/Skype-for-Chrome/pull/15 seems to have fixed this. I suspect it was a bug in the jquery-replacetext library that the plugin uses. The pull request included an updated version.