jacksondunstan / UnityNativeScripting

Unity Scripting in C++
https://jacksondunstan.com/articles/3938
MIT License
1.33k stars 135 forks source link

Bindings generator does not handle multiple derived types #68

Open philipcass opened 3 years ago

philipcass commented 3 years ago

I've noticed when you have several classes based of the same abstract class the codegen can't handle it even thought the syntax looks like it should e.g.

        {
            "Name": "MyNamespace.AbstractShape",
            "BaseTypes": [
                {
                    "BaseName": "MyNamespace.BaseSquare",
                    "DerivedName": "MyNamespace.Square"
                },
                {
                    "BaseName": "MyNamespace.BaseCircle",
                    "DerivedName": "MyNamespace.Circle"
                }
            ]
        }

Doesn't work

jacksondunstan commented 3 years ago

@philipcass Can you please elaborate on what doesn't work?

philipcass commented 3 years ago

@jacksondunstan When generating c sharp delegates for each instance of the derived types the code-gen redeclares the common abstract methods multiple times e.g. if GetRadius was declared in AbstractShape it'd create this twice:

        [UnmanagedFunctionPointer(CallingConvention.Cdecl)]
        public delegate double MyNamespaceAbstractShapeGetRadiusDelegateType(int thisHandle);
        public static MyNamespaceAbstractShapeRadiusDelegateType MyNamespaceAbstractShapeGetRadiusDelegateType;
jacksondunstan commented 3 years ago

@philipcass Thanks for clarifying. It looks like that code should only be generated for the first derived type, not all of them. I'm not able to address the issue right away, but please do feel free to submit a PR with a fix.