jacksonh / manos

Manos is an easy to use, easy to test, high performance web application framework that stays out of your way and makes your life ridiculously simple.
Other
455 stars 61 forks source link

manos does not compile on Windows 7 #113

Open MarkKharitonov opened 13 years ago

MarkKharitonov commented 13 years ago
"z:\dev\3rd_party\Manos\src\Manos\Manos.WithHints.proj" (default target) (1) -> (CoreCompile target) ->
  Manos.Http\HttpEntity.cs(521,5): error CS0165: Use of unassigned local variable 'completeWatcher' [z:\dev\3rd_party\Manos\src\Manos\Manos.WithHints.proj]
  Manos.Http\HttpTransaction.cs(176,5): error CS0165: Use of unassigned local variable 'handler' [z:\dev\3rd_party\Manos\src\Manos\Manos.WithHints.proj]
  Manos\AppHost.cs(208,6): error CS0165: Use of unassigned local variable 'timer' [z:\dev\3rd_party\Manos\src\Manos\Manos.WithHints.proj]

    1 Warning(s)
    3 Error(s)

Time Elapsed 00:00:01.00

z:\dev\3rd_party\Manos\src\Manos>

Where Manos.WithHints.proj is simply my wrapper around Manos.csproj to avoid modifying it:

<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build" ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <ItemGroup>
    <Reference Include="Mono.Posix" >
      <HintPath>..\..\Dependencies\Mono.Posix.dll</HintPath>
    </Reference>
    <Reference Include="Mono.CSharp" >
      <HintPath>..\..\Dependencies\Mono.CSharp.dll</HintPath>
    </Reference>
    <Reference Include="Mono.C5" >
      <HintPath>..\..\Dependencies\Mono.C5.dll</HintPath>
    </Reference>
  </ItemGroup>
  <Import Project="Manos.csproj" />
</Project>

I am using revision 33a14b0 pulled July 10.

imphasing commented 13 years ago

I've submitted a pull request that fixes this issue. If you'd like to check out my patch, it's very simple. I just assign the closed-over variable the compiler is complaining about in the delegate to null first, so it's not unsure if it's ever going to be assigned.

MarkKharitonov commented 13 years ago

I did fix it in my working copy, it is just that it was a bit unexpected.

2011/7/13 imphasing < reply@reply.github.com>

I've submitted a pull request that fixes this issue. If you'd like to check out my patch, it's very simple. I just assign the closed-over variable the compiler is complaining about in the delegate to null first, so it's not unsure if it's ever going to be assigned.

Reply to this email directly or view it on GitHub: https://github.com/jacksonh/manos/issues/113#issuecomment-1563645

Be well and prosper.

"There are two kinds of people.Those whose guns are loaded and those who dig." ("The good, the bad and the ugly") So let us drink for our guns always be loaded.