search

jacksonh / manos

Manos is an easy to use, easy to test, high performance web application framework that stays out of your way and makes your life ridiculously simple.
Other
453 stars 61 forks source link

Windows support (properly this time) #77

Closed carlokok closed 13 years ago

headsling commented 13 years ago

Thanks for coming back with this! Its going to take a couple of days to look at this; Jackson has got some fairly big changes going in this weekend and I need to re-life my Windows environment. I'll come back to you with some questions shortly.

cheers

carlokok commented 13 years ago

note that the same code at least should work on linux; If you manually assign the ioloop setter before it's read to a new instance of the new class.

headsling commented 13 years ago

Carlo - please see my direct message to you. cheers

headsling commented 13 years ago

on it now

headsling commented 13 years ago

Carlo - can you take a look at the changes to AppHost.cs ? IOLoop isn't responsible for creating sockets anymore, so we need to come up with a way of getting the correct version of PlainSocketStream based on the current loop implementation.

Also I notice that the sendfile_NOSENDFILE file is missing now in your pull - is that intentional?

i've removed the "if (Request == null) return;" statement from the HttpTransaction::OnResponseFinished - not clear why it's there.

cheers

headsling commented 13 years ago

things look good - if we get my last q's sorted then i'm ready to commit

carlokok commented 13 years ago

Carlo - can you take a look at the changes to AppHost.cs ? IOLoop isn't responsible for creating sockets anymore, so we need to come up with a way of getting the correct version of PlainSocketStream based on the current loop implementation.

Afaik my changes cover that, support both secure and plain through the ioloop implementation, and picking the right implementation.

Also I notice that the sendfile_NOSENDFILE file is missing now in your pull - is that intentional?

Yes, that's not needed anymore, I wrote a new one that supported chunked, based on the existing copying one but fully managed.

i've removed the "if (Request == null) return;" statement from the HttpTransaction::OnResponseFinished - not clear why it's there.

ke. I think that was merged in.

cheers

headsling commented 13 years ago

merged - thanks

jacksonh commented 13 years ago

Great work guys.