jacksonh / manos

Manos is an easy to use, easy to test, high performance web application framework that stays out of your way and makes your life ridiculously simple.
Other
455 stars 61 forks source link

IO split patch review #93

Closed ghost closed 13 years ago

ghost commented 13 years ago

The IO split draft currently at jacksonh/manos@791a0e6d88dd51689a4f should be reviewed before we merge it into master. All major issues i encountered during my tests are fixed, and benchmarks show little to no performance degradation. Explanation for "little": the managed IO code didn't guarantee some things the libev IO code did guarantee, and as a consequence, http transaction and managed IO did not get along too well. That is fixed with a rather nasty workaround for time being.

Major points of the changeset:

any feedback is welcome.

ghost commented 13 years ago

I guess non-objection is a silent nod. If that's the case, I'll simply merge soon.

ghost commented 13 years ago

Merged.