search

jacksonh / manos

Manos is an easy to use, easy to test, high performance web application framework that stays out of your way and makes your life ridiculously simple.
Other
455 stars 61 forks source link

TimerWatchers not working under Windows #94

Closed toptensoftware closed 13 years ago

toptensoftware commented 13 years ago

Seems TimerWatchers don't work under Windows. Issues found:

  1. TimerWatcher.Start() is never called meaning the System.Threading.Timer never fires
  2. System.Threading.Timer callbacks can be re-entrant
  3. Multiple timer events can be queued causing single shot timers to fire multiple times.

Here's the fixes I made:

https://github.com/toptensoftware/manos/commit/3acdcc04c4f32eb3e87ab2641b1b717704cb0afb

ghost commented 13 years ago

Thank you, I will take a look at your changes as soon as possible.

ghost commented 13 years ago

Should be fixed now.

toptensoftware commented 13 years ago

Found another problem here where the System.Threading.Timer continues to run silently in the background. Fix is available in my current pull request or here:

https://github.com/toptensoftware/manos/commit/4ef3df5ede9a84cd2e88d75c511376b6b0eb9114

ghost commented 13 years ago

Thank you, I'll apply that one too.