search

jacksonh / manos

Manos is an easy to use, easy to test, high performance web application framework that stays out of your way and makes your life ridiculously simple.
Other
454 stars 61 forks source link

Request for new Route() overload #97

Closed toptensoftware closed 13 years ago

toptensoftware commented 13 years ago

Any chance this overload for the Route() method can be added (includes an extra final parameter to declare the http methods to match).

public RouteHandler Route(string pattern, MatchType matchType, ManosAction action, HttpMethod[] methods)
{
    IMatchOperation[] ops = OpsForPatterns(new string[] { pattern }, matchType);
    return AddRouteHandler(action, ops, methods);
}

I'm building a lightweight MVC framework around Manos and so far this is the only change I've had to make to Manos itself.

ghost commented 13 years ago

I don't see why not. Can you attach a range of commits that adds this from your fork?

toptensoftware commented 13 years ago

Not sure how to send a pull request for just one of my commits. Here's my commit:

https://github.com/toptensoftware/manos/commit/a55329fc7c0486caaeff87539d75063d69198e92

toptensoftware commented 13 years ago

Figured out how to send a pull request. Resent. Closing issue