search

jacksonlcrews / darkice

Automatically exported from code.google.com/p/darkice
0 stars 0 forks source link

Loop with AAC and AAC+ encoders #83

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. use aac or aacp format (in icecast2 configuration)
2. the associated thread will use all the available CPU

What version of the product are you using? On what operating system?
Darkice 1.1 or SVN

Please provide any additional information below.

According to our debugs, FaacEncoder and aacPlusEncoder write methods return an 
incorrect value. The expected returns is the processed bytes count (like lame 
or vorbis encoders). FaacEncoder and aacPlusEncoder return processed samples 
count. BufferedSink fails to write its complete content in these encoders and 
loops.

Here is a patch to fix the problem :
https://github.com/tryphon/darkice/commit/c45aee4ddd84ae59400ef180bf59c83f576d75
73

Original issue reported on code.google.com by alban.pe...@gmail.com on 3 Apr 2013 at 7:15

GoogleCodeExporter commented 9 years ago 
Already applied, thanks!

Original comment by rafael2k...@gmail.com on 14 May 2013 at 3:32