jacksonlcrews / darkice

Automatically exported from code.google.com/p/darkice
0 stars 0 forks source link

r522: configure/autogen.sh does not check for libopus-dev #87

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Prepare test system with all needed libs/headers but not libopus-dev
2. configure and build darkice r522
3.

What is the expected output? What do you see instead?
Configure should notice missing libopus-dev and either disable opus support 
(justr like it does with aacplus) or if not possible it should at least break 
because of missing libopus-dev

Instead configure runs without error, but compile breaks on missing opus header.

What version of the product are you using? On what operating system?
darkice svn r522 on Ubuntu 13.04

Please provide any additional information below.

Original issue reported on code.google.com by daniel.e...@gmail.com on 14 May 2013 at 8:45

GoogleCodeExporter commented 9 years ago
confirmered : on Ubuntu 10.04.4 LTS 

Original comment by oetelaar.automatisering on 15 May 2013 at 7:40

GoogleCodeExporter commented 9 years ago
./configure --without-opus

reports 
checking for vorbis libraries at /usr ... found at /usr 
****** building without Ogg Opus ******
checking for faac library at /usr ... found at /usr 

but it is not possible to build it without.
compiler reports # error when #ifdef HAVE_OPUS_LIB not true

In file included from DarkIce.cpp:96:
OpusLibEncoder.h:47:2: error: #error configure for Ogg Opus

So it is not possible to build without opus lib enabled.

Original comment by oetelaar.automatisering on 15 May 2013 at 11:52

GoogleCodeExporter commented 9 years ago
fixed in 527

Original comment by oetelaar.automatisering on 16 May 2013 at 8:17

GoogleCodeExporter commented 9 years ago

Original comment by oetelaar.automatisering on 16 May 2013 at 8:18

GoogleCodeExporter commented 9 years ago
confirmed, r527 builds and runs fine without opus

Original comment by daniel.e...@gmail.com on 16 May 2013 at 8:32