`hkcancor_to_ud` typo: "G1": "V" should be "VERB"

jacksonllee / pycantonese

Cantonese Linguistics and NLP

https://pycantonese.org

MIT License

354 stars 38 forks source link

`hkcancor_to_ud` typo: "G1": "V" should be "VERB" #48

Closed AlienKevin closed 4 months ago

AlienKevin commented 4 months ago

The _MAP for the pos_tagging.hkcancor_to_ud function has a typo that incorrectly outputs the V as a UD tag when VERB is intended. This breaks downstream tasks that rely on pycantonese to convert hkcancor labels into UD.

jacksonllee commented 4 months ago

@AlienKevin Thank you for catching the typo and creating this issue! I've just fixed it at the upstream main branch, so for now you can get the fixed pycantonese package by installing it from the github source:

pip install git+https://github.com/jacksonllee/pycantonese.git