search

jackstenglein / chess-dojo-scheduler

8 stars 10 forks source link

Remove grayscreen effect from "Choose Variation" prompt (game editor) #723

Open hellokostya opened 2 months ago

hellokostya commented 2 months ago

It's hard to play through a game quickly that has a lot of notes, because of the constant grayscreen, can we remove that and just have the variation box pop up on the top right side of the notes? I think that's the best place for it because if someone is interested in the variations, they'll probably be looking at the right side of the screen

jackstenglein commented 2 months ago

@hellokostya How's this? Personally I think it makes it more difficult both to notice the dialog has popped up, and to read the notes when the dialog is there.

Screenshot 2024-08-23 at 5 25 37 PM
jackstenglein commented 2 months ago
Screenshot 2024-08-23 at 5 37 25 PM
jackstenglein commented 2 months ago

@hellokostya I'm pushing up the version in the second screenshot for now. Let me know if further updates are needed. If not, please close this.

hellokostya commented 2 months ago

@jackstenglein Looks good to me! Only issue with the variation box is while it's open, using the down arrow key to select a variation also scrolls the page down, which is a bit annoying

jackstenglein commented 1 month ago

@hellokostya What browser/OS are you using? I've tested with Chrome/Firefox on Mac and Chrome on Windows and the down arrow key doesn't scroll the page down when the variation dialog is open

hellokostya commented 1 month ago

Using Chrome on Windows 11, just checked and it's still doing it

On Thu, Sep 5, 2024 at 1:25 AM Jack Stenglein @.***> wrote:

@hellokostya https://github.com/hellokostya What browser/OS are you using? I've tested with Chrome/Firefox on Mac and Chrome on Windows and the down arrow key doesn't scroll the page down when the variation dialog is open

— Reply to this email directly, view it on GitHub https://github.com/jackstenglein/chess-dojo-scheduler/issues/723#issuecomment-2330315178, or unsubscribe https://github.com/notifications/unsubscribe-auth/BJITVIBDPQ3PXNLRQX5T7Q3ZU6JFFAVCNFSM6AAAAABM2HI662VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZQGMYTKMJXHA . You are receiving this because you were mentioned.Message ID: @.***>

jackstenglein commented 1 month ago

@hellokostya I pushed up a change which I think may have fixed that. Could you check again please?