search

jacktasia / dumb-jump

an Emacs "jump to definition" package for 50+ languages
GNU General Public License v3.0
1.58k stars 151 forks source link

Should dumb-jump use (thing-at-point 'sexp) instead of (thing-at-point 'symbol) ? #179

Open ahungry opened 6 years ago

ahungry commented 6 years ago

Some very rough preliminary testing shows them to return the same results in a few different file types that I've checked, however in Common Lisp, this is a valid function call/name for a function titled #/something:

(#/something "here")

If the cursor is on the #, it won't find a valid symbol, while it will find the match if using the sexp type (I assume the sexp is just grabbing until the first whitespace.

Granted, this is quite unusual, especially considering CL uses the sharpsign as a way to reference functions like #'symbol-name as well.

Thoughts?

jacktasia commented 6 years ago

Thanks for opening this! You're definitely on to something and this may be the proper solution for the likes of #168 and #174 (vs what I actually did). I thought I had started with sexp then moved over to using symbol (for a reason I can't remember) but after a very quick look I can't find evidence of this.

I am definitely going to look closer into this tonight or this weekend and report back. Thanks again for opening this!

ahungry commented 6 years ago

Thank you for a wonderful package and prompt response!