search

jacktasia / dumb-jump

an Emacs "jump to definition" package for 50+ languages
GNU General Public License v3.0
1.57k stars 150 forks source link

Failing tests for php #337

Closed cweiske closed 3 years ago

cweiske commented 4 years ago

"dumb-jump-php-method-static" works locally, but not in docker (no idea why, sorry)

"dumb-jump-php-method-normal" searches for "$user->getSelf", but the symbol should be "getSelf" only. I do not know why it does not search for "getSelf" here.

cweiske commented 4 years ago

(this PR is meant as a base for discussion)

jacktasia commented 4 years ago

"dumb-jump-php-method-normal" searches for "$user->getSelf", but the symbol should be "getSelf" only. I do not know why it does not search for "getSelf" here.

(thing-at-point 'symbol) is being used under the hood. if you're in fundamental (no) mode that will be $user->getSelf if it's in php-mode it will be getSelf

it might be enough to just do what's happening in dumb-jump-get-lang-major-mode-test