search

jacktasia / dumb-jump

an Emacs "jump to definition" package for 50+ languages
GNU General Public License v3.0
1.57k stars 150 forks source link

Mark legacy commands as obsolete #349

Closed phikal closed 4 years ago

phikal commented 4 years ago

Something along these lines was originally implemented in #343, but I decided to leave it out since it's a different issue.

Marking the commands as obsolete doesn't break anything, so backwards compatibility is ensured. Furthermore, this will only take effect if xref is installed, so the theoretical Emacs 24.1 user won't be annoyed ^^.

If you're not interested in obsoleting the old commands, please feel free to say so. If that's the case, I continue developing the changes from #334 into it's own fork, since it has basically been rewritten 100%, dropping all backwards compatibility so that it may be merged into ELPA.

jacktasia commented 4 years ago

Thanks!

amno1 commented 4 years ago

I would definitely like to keep them not obsolete and to have them as interface into dumb-jump so I don't need to rebind my keys and what not.

phikal commented 4 years ago

Arthur Miller notifications@github.com writes:

I would definitely like to keep them not obsolete and to have them as interface into dumb-jump so I don't need to rebind my keys and what not.

The whole point is that you don't have to rebind anything. Xref's "go to definition" is already bound by default (M-. is bound to the command xref-find-definitions). All you need to do is register the backend, but as the README explains, that's a single line of elisp.

-- Philip K.