search

jacktasia / dumb-jump

an Emacs "jump to definition" package for 50+ languages
GNU General Public License v3.0
1.57k stars 150 forks source link

reference to free variable find-tag-marker-ring #373

Open diamond-lizard opened 3 years ago

diamond-lizard commented 3 years ago

When byte-compiling dumb-jump, I get this warning:

In dumb-jump-goto-file-line:
dumb-jump.el:2531:18:Warning: reference to free variable
    ‘find-tag-marker-ring’
phikal commented 3 years ago

What version of Emacs are you using?

diamond-lizard commented 3 years ago

27.1

phikal commented 3 years ago

Ah, so it's this line, and the issue is that find-tag-marker-ring is defined in etags, but you apparently didn't load that feature. It's included for backwards-compatibility reasons, for versions of Emacs that didn't come with xref (that's <=24.4).

It could be supressed by adding another test before calling find-tag-marker-ring (see Elisp manual, (elisp) Compiler Errors).