search

jacktasia / dumb-jump

an Emacs "jump to definition" package for 50+ languages
GNU General Public License v3.0
1.57k stars 150 forks source link

Fix xrefs for remote connections over TRAMP #432

Closed gsingh93 closed 4 months ago

gsingh93 commented 1 year ago

Haven't done much extensive testing with this, but it fixes #413 for me.

gsingh93 commented 1 year ago

@jacktasia would you be able to take a look at this to see if it's the proper fix?

mrunhap commented 4 months ago

@jacktasia would you be able to take a look at this to see if it's the proper fix?

prashantvithani commented 3 months ago

@jacktasia This patch has actually broken dumb-jump-go. It blindly adds tramp-path-prefix to a relative path, which is already added dumb-jump--result-follow as part of default-directory (default directory is ssh:host:path/to/dir and relative path in the results is always corresponding to default-directory.

Reverting this patch locally fixes it.