jacktasia / dumb-jump

an Emacs "jump to definition" package for 50+ languages
GNU General Public License v3.0
1.57k stars 150 forks source link

Add generic rule for matching all clojure def types #439

Closed npcoder2k14 closed 1 year ago

npcoder2k14 commented 1 year ago

Above function wouldn't be matched even if it is defined using defn.

Test:

npcoder2k14 commented 1 year ago

@jacktasia Could you please review this PR?

jacktasia commented 1 year ago

Thanks for the PR @npcoder2k14, but it looks like this regex is failing for some of the searchers (git grep, grep, rg): https://github.com/jacktasia/dumb-jump/actions/runs/5510440193/jobs/10044649995?pr=439#step:6:542

npcoder2k14 commented 1 year ago

Thanks for the response @jacktasia. I'll fix it in a couple of days.

npcoder2k14 commented 1 year ago

@jacktasia I have fixed the commit and ran all tests locally. 🤞 Please check it now.

Side note: I have updated the last commit instead of creating a new commit fix commit. I am back to github after a long time so my understanding of github workflows is clanky at the moment. (I use gerrit at my workplace) Let me know if I need to do something different here.

npcoder2k14 commented 1 year ago

Builds are failing due to the python version upgrade.

jacktasia commented 1 year ago

Builds are failing due to the python version upgrade.

Interesting, because the initial run didn’t work because the old version wasn’t there any more. Now the new version it wanted before seems to be gone.