Closed npcoder2k14 closed 1 year ago
@jacktasia Could you please review this PR?
Thanks for the PR @npcoder2k14, but it looks like this regex is failing for some of the searchers (git grep, grep, rg): https://github.com/jacktasia/dumb-jump/actions/runs/5510440193/jobs/10044649995?pr=439#step:6:542
Thanks for the response @jacktasia. I'll fix it in a couple of days.
@jacktasia I have fixed the commit and ran all tests locally. 🤞 Please check it now.
Side note: I have updated the last commit instead of creating a new commit fix commit. I am back to github after a long time so my understanding of github workflows is clanky at the moment. (I use gerrit at my workplace) Let me know if I need to do something different here.
Builds are failing due to the python version upgrade.
Builds are failing due to the python version upgrade.
Interesting, because the initial run didn’t work because the old version wasn’t there any more. Now the new version it wanted before seems to be gone.
deftest
or a function with metadata.Above function wouldn't be matched even if it is defined using
defn
.Test: