jacktuck / unfurl

Metadata scraper with support for oEmbed, Twitter Cards and Open Graph Protocol for Node.js :zap:
MIT License
474 stars 51 forks source link

feat: adding theme-color meta data #104

Closed andyford closed 1 year ago

andyford commented 1 year ago

adds support for the theme-color meta tag making it available as theme_color at the top level of the response object.

Side note: I noticed that the test in /test/basic/tests.ts labeled should detect title, description and keywords appears to be there twice. I wasn't sure if there was any reason for this though. Should the duplicate be removed? And should the label of the remaining de-duped test read more like should detect favicon, author, description, keywords, title, and theme_color (just to be more accurate)?

jacktuck commented 1 year ago

Thanks

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 6.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

andyford commented 1 year ago

Thanks

thank YOU! 👍