search

jacktuck / unfurl

Metadata scraper with support for oEmbed, Twitter Cards and Open Graph Protocol for Node.js :zap:
MIT License
475 stars 51 forks source link

Extract website icon #28

Closed vivekatro closed 6 years ago

vivekatro commented 6 years ago

First of all, awesome work! It would be great we you can extract the site icon in the response as well :)

jacktuck commented 6 years ago

@vivekatro Thanks for the kind words.

I think I'd like to keep the library as simple as possible and just return all possible metadata which would let you search for the icon yourself. Rather than handling the many varying cases someone might want to scrape a website.

That said if anything is missing and blocking you from fetching the icon that's something i'd definitely take a look at fixing.

Please re-open if you find any missing metadata that blocks you. Thanks again :)